comparators.ts ➔ compareNumbers - Code Metrics - Inspection of "feat: refactor core logic" - tamtamchik/json-deep-sort - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feat/refactoring ( 415766 )

by Yuri

created 2025-08-10 12:40 UTC

comparators.ts ➔ compareNumbers A

↳ Parent: src/comparators.ts

Complexity

Conditions

Size

Total Lines	11
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	5

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	11
ccs	5
cts	5
cp	1
rs	9.3333
c	0
b	0
f	0
cc	5
crap	5

// Comparison functions for different data types
export function compareSortablePrimitives(
  a: unknown,
  b: unknown,
  ascending: boolean
): number {
  if (typeof a === 'string' && typeof b === 'string') {
    return ascending ? a.localeCompare(b) : b.localeCompare(a);
  }

  if (typeof a === 'number' && typeof b === 'number') {
    return compareNumbers(a, b, ascending);
  }

  if (typeof a === 'boolean' && typeof b === 'boolean') {
    return compareBooleans(a, b, ascending);
  }

  return 0; // Maintain order for other primitives
}

export function compareNumbers(
  a: number,
  b: number,
  ascending: boolean
): number {
  if (Number.isNaN(a) && Number.isNaN(b)) return 0;
  if (Number.isNaN(a)) return 1;
  if (Number.isNaN(b)) return -1;

  return ascending ? a - b : b - a;
}

export function compareBooleans(
  a: boolean,
  b: boolean,
  ascending: boolean
): number {
  if (a === b) return 0;
  if (a) return ascending ? 1 : -1;
  return ascending ? -1 : 1;
}

export function compareObjectKeys(
  keyA: string | symbol,
  keyB: string | symbol,
  ascending: boolean
): number {
  if (typeof keyA === 'symbol' && typeof keyB === 'symbol') return 0;
  if (typeof keyA === 'symbol') return 1;
  if (typeof keyB === 'symbol') return -1;

  const stringA = keyA as string;
  const stringB = keyB as string;

  return ascending
    ? stringA.localeCompare(stringB)
    : stringB.localeCompare(stringA);
}


1		// Comparison functions for different data types
2	1	export function compareSortablePrimitives(
3		a: unknown,
4		b: unknown,
5		ascending: boolean
6		): number {
7	168	if (typeof a === 'string' && typeof b === 'string') {
8	40	return ascending ? a.localeCompare(b) : b.localeCompare(a);
9		}
10
11	128	if (typeof a === 'number' && typeof b === 'number') {
12	83	return compareNumbers(a, b, ascending);
13		}
14
15	45	if (typeof a === 'boolean' && typeof b === 'boolean') {
16	21	return compareBooleans(a, b, ascending);
17		}
18
19	24	return 0; // Maintain order for other primitives
20		}
21
22	1	export function compareNumbers(
23		a: number,
24		b: number,
25		ascending: boolean
26		): number {
27	83	if (Number.isNaN(a) && Number.isNaN(b)) return 0;
28	81	if (Number.isNaN(a)) return 1;
29	77	if (Number.isNaN(b)) return -1;
30
31	71	return ascending ? a - b : b - a;
32		}
33
34	1	export function compareBooleans(
35		a: boolean,
36		b: boolean,
37		ascending: boolean
38		): number {
39	21	if (a === b) return 0;
40	13	if (a) return ascending ? 1 : -1;
41	6	return ascending ? -1 : 1;
42		}
43
44	1	export function compareObjectKeys(
45		keyA: string \| symbol,
46		keyB: string \| symbol,
47		ascending: boolean
48		): number {
49	102	if (typeof keyA === 'symbol' && typeof keyB === 'symbol') return 0;
50	100	if (typeof keyA === 'symbol') return 1;
51	95	if (typeof keyB === 'symbol') return -1;
52
53	95	const stringA = keyA as string;
54	95	const stringB = keyB as string;
55
56	95	return ascending
57		? stringA.localeCompare(stringB)
58		: stringB.localeCompare(stringA);
59		}
60

tamtamchik / json-deep-sort

Push — feat/refactoring ( 415766 )

comparators.ts ➔ compareNumbers A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like